Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Fix Enum.Parse's parse failure exception to include value in error message #57975

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 23, 2021

Backport of #57945 to release/6.0

/cc @stephentoub

Customer Impact

Exception message coming from Enum.Parse isn't as helpful as it previously was (and looks wrong, with '' in the message where there's obviously supposed to be a value).

Testing

Added new test for CI

Risk

Minimal change, low risk on an exception path. Primary concern would be if it somehow regressed perf, but I didn't measure any impact locally.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@stephentoub
Copy link
Member

cc: @danmoseley

@danmoseley
Copy link
Member

approved for 6.0 -- significant regression if you're debugging, low risk localized change.

@stephentoub stephentoub merged commit 3de61d6 into release/6.0 Aug 25, 2021
@stephentoub stephentoub deleted the backport/pr-57945-to-release/6.0 branch August 25, 2021 02:07
@ghost ghost locked as resolved and limited conversation to collaborators Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants