Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Fix nullable annotations for AssociatedMetadataTypeTypeDescriptionProvider #57979

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 23, 2021

Backport of #57932 to release/6.0

/cc @stephentoub

Customer Impact

Minor APIs weren't annotated as part of the TypeConverter annotations. This adds those annotations.

Testing

It compiles.

Risk

Minimal. It's purely annotation, no functional changes.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Aug 23, 2021

Tagging subscribers to this area: @ajcvickers, @bricelam, @roji
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #57932 to release/6.0

/cc @stephentoub

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-System.ComponentModel.DataAnnotations, new-api-needs-documentation

Milestone: -

@stephentoub
Copy link
Member

@jeffhandley, I went ahead and asked the bot to backport this as part of finishing netcoreapp annotations. But feel free to close this if you don't think it's warranted.

cc: @danmoseley

@danmoseley
Copy link
Member

approved for release/6.0 as negligible risk with some visible customer benefit. we'd probably reject this a bit later.
thanks for doing it.

@danmoseley danmoseley merged commit ae5737e into release/6.0 Aug 24, 2021
@danmoseley danmoseley deleted the backport/pr-57932-to-release/6.0 branch August 24, 2021 22:43
@ghost ghost locked as resolved and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants