[release/6.0-rc1] [interp] Use existing InterpMethod if allocation and lookup race #57985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
If two threads both want to get an InterpMethod for the same MonoMethod, and they both see null from the first hash table lookup, make sure that whichever one comes into the jit_mm lock second re-uses the previously inserted InterpMethod, instead of its own version. Without this change, racing threads will overwrite MonoJitInfo:seq_points (in mono_interp_transform_method) which sometimes leads to deallocating the same sequence points multiple times. Fixes #57812
|
Tagging subscribers to this area: @BrzVlad Issue DetailsBackport of #57968 to release/6.0-rc1 /cc @lambdageek Customer ImpactTestingRisk
|
|
@marek-safar ok for 6.0? |
SteveMCarroll
added
Servicing-approved
thaystg
approved these changes
Aug 24, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #57968 to release/6.0-rc1
/cc @lambdageek
#57812
Customer Impact
In mobile devloop scenarios (which will use the interpreter by default), multi-threaded programs that execute the same method on multiple threads may crash.
Testing
CI
Risk
Low - on wasm we're single-threaded; on mobile in release configurations we don't use the interpreter. And as a mitigation, it is possible to use the JIT for debug configurations with both Android and iOS.