[release/6.0-rc1] [wasm][debugger] Proxy but don't process events from worker sessions #57990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @thaystg |
thaystg
approved these changes
Aug 24, 2021
SteveMCarroll
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #57974 to release/6.0-rc1
/cc @lewing
Customer Impact
Speculative fix for #57949 where debugging a wasm app fails completely under certain scenarios. The change transparently proxies certain events instead of processing them which was the cause of the failure, and we'd like to get it verified in rc1.
Testing
Manually verified it does not regress existing scenarios. The failure case is difficult to test with our current infrastructure but the change is logically correct and does not regress existing tests.
Risk
Very low. The change avoids a clear failure case.