[release/6.0] Fix enum memory code paths #58076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #57981 to release/6.0 /cc @mikem8361 @cshung Customer ImpactTestingRisk
|
mikem8361
approved these changes
Aug 24, 2021
jeffschwMSFT
approved these changes
Aug 24, 2021
|
Hello @mikem8361! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Apologies, while this PR appears ready to be merged, it looks like |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #57981 to release/6.0
/cc @mikem8361 @cshung
Customer Impact
This issue caused dump generated with createdump or
dotnet-dump collectto be incomplete so SOS and debugging these dumps fails.Testing
Ran successfully all the SOS/dump generation tests in the diagnostics repo against the changes.
Risk
Low risk. The change only affects the EnumMemoryRegions API in the DAC that the dump generation uses.