[release/6.0] [mono] Use string.Empty for empty string custom arg values #58113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
lambdageek,
thaystg and
vargaz
as code owners
|
Tagging subscribers to this area: Issue DetailsBackport of #58023 to release/6.0 /cc @lambdageek @uweigand Customer ImpactTestingRisk
|
lambdageek
approved these changes
Aug 25, 2021
|
Is a unit test infeasible? |
And not a new string object that happens to be `""` Adds a testcase for #58023
|
Added a test. Also in #58197 for |
marek-safar
reviewed
Aug 27, 2021
| *out_obj = (MonoObject*)mono_string_new_wtf8_len_checked (p, slen, error); | ||
| // Always use string.Empty for empty strings | ||
| if (slen == 0) | ||
| *out_obj = (MonoObject*)mono_string_empty_internal (mono_domain_get ()); |
There was a problem hiding this comment.
nit: wouldn't mono_string_empty_wrapper be better?
There was a problem hiding this comment.
that one is marked MONO_RT_EXTERNAL_ONLY so cannot be used in runtime code.
marek-safar
removed
the
Servicing-consider
marek-safar
approved these changes
Aug 27, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58023 to release/6.0
/cc @lambdageek @uweigand
Customer Impact
Discovered while running ASP.NET Core tests on the S390x port. Kestrel assumes that custom attribute values are reference-equal to
string.Empty, not some other empty string value.Testing
Manual testing and CI
Risk
Very low - code would have to rely on Mono's custom attribute implementation to return fresh string objects to be affected.