Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the
SourceBuildNonPortable
switch control? I don't see it yet being used in the repo anywhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the switch that we pass in from source-build to do a portable or non-portable build. In the source-build tarball build,
it builds runtime both portable and non-portable. In the non-portable case, we pass this flag. https://github.com/dotnet/installer/blob/fd550a3dacfda14c19c0c96ce7a7243e90a13ea5/src/SourceBuild/tarball/content/repos/runtime.proj#L12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I meant is, where is the logic that controls which subset of runtime is built during a source build portable build? I would have expected that the
SourceBuildNonPortable
property appears in Subsets.props to control what of runtime is built during a portable build.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no difference in subsets between portable and non-portable. The only change is to only build allconfigurations when building a non-portable build.