Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Surface allocations per thread #58123

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 25, 2021

Backport of #57773 to release/6.0

/cc @mikem8361 @hoyosjs @tommcdon

Customer Impact

Adds the interface necessary for VS to display per-thread GC allocations.

Testing

The VS team (Gabrielle Chen) confirmed that the new feature is working with these changes.

Risk

Low.

@ghost
Copy link

ghost commented Aug 25, 2021

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #57773 to release/6.0

/cc @mikem8361 @hoyosjs

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-Diagnostics-coreclr

Milestone: -

@mikem8361 mikem8361 self-assigned this Aug 25, 2021
@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Aug 25, 2021
@jeffschwMSFT jeffschwMSFT added this to the 6.0.0 milestone Aug 25, 2021
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please get a code review and we will take for consideration in RC2.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@davidwrighton davidwrighton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've examined this in detail and lgtm

@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 26, 2021
@Anipik Anipik merged commit be6bd3d into release/6.0 Aug 26, 2021
@hoyosjs hoyosjs deleted the backport/pr-57773-to-release/6.0 branch August 26, 2021 18:57
@ghost ghost locked as resolved and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants