[release/6.0] Handle shadowed property names in DiagnosticsSourceEventSource #58212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58145 to release/6.0
/cc @josalem
fixes #57709
Customer Impact
If a class, such as SqlLiteCommand, has a shadowed property name, such as SqlLiteCommand.Connection and DbCommand.Connection, the logic in DiagnosticSourceEventSource will throw an ambiguous match exception when trying to resolve a property with that name.
This causes the database collector in VS and potentially others to cause the target to throw and exception.
Testing
Added a test as part of the patch that tests the scenario intended to fix. Currently collecting offline confirmation from VS that this indeed fixes their scenario.
Risk
Minimal. This patch enables the new metrics functionality added in 6 while fixing a regression from previous versions.
CC @davidmikh @tarekgh @davmason