Only look for exceptVars when resolving live-out EH vars #58243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsWhen resolving ResolveJoin edge, only consider except var
|
|
@dotnet/jit-contrib |
kunalspathak
changed the title
|
I have run superpmi-replay on jitstressregs and it is green. No asmdiff although it is surprising that how this oversight was not caught until now. |
BruceForstall
approved these changes
Aug 28, 2021
|
Since this issue existing pre-.NET6 and this is not customer reported issue but something that fuzzer found, I am hesitant to port it back to .NET6. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resolving
ResolveJoinedge for live out EH vars, we should only consider the EH var register candidates instead of all the register candidates.Fixes: #58083