[release/6.0] Implement Environment.GetEnvironmentVariables for Apple platforms using official API for iOS/tvOS/MacCatalyst #58254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng official API (dotnet#58161) Move environment handling from Mono runtime to System.Native Fixes dotnet#58156 Co-authored-by: Alexander Köplinger <[email protected]> Co-authored-by: Adeel Mujahid <[email protected]>
akoeplinger
requested review from
lambdageek,
lateralusX,
thaystg and
vargaz
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
lateralusX
reviewed
Aug 27, 2021
marek-safar
approved these changes
Aug 27, 2021
lambdageek
approved these changes
Aug 27, 2021
akoeplinger
removed
the
Servicing-consider
|
@lambdageek backports to RC2 only need M2 approval (i.e. Marek), so we don't need the Servicing-consider label. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58161 to release/6.0 branch
Customer Impact
After calling
Environment.GetEnvironmentVariables()if you tried to retrieve a single environment variable (e.g.HOME) you'd get an empty result. The reason is thatEnvironment.GetEnvironmentVariables()retrieves and then caches a dictionary of all available environment variables which are then also used forEnvironment.GetEnvironmentVariable(string variable). The problem was that we used to return an empty array for the environment variables in the runtime for iOS/tvOS (which worked fine in mono/mono since we didn't have this caching in the managed layer).#58161 fixes this by properly implementing a way to get all available environment variables.
Testing
Manual testing on iOS arm64 device. Verified single environment variables can be accessed even after calling
Environment.GetEnvironmentVariables()and that the API returns all the env vars.Risk
Low. We return environment variables now where we used to return an empty dictionary.
Fixes #58156