Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Use OutputRid in test projects #58340

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 30, 2021

Properly pass the RID to the CORE_ROOT generation logic.

Backport of #58166 to release/6.0

/cc @hoyosjs @am11

Customer Impact

Without this, testing arm variants in outerloop for servicing is not possible.

Testing

CI tests

Risk

Really low, Test only impact.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Aug 30, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #58166 to release/6.0

/cc @hoyosjs @am11

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure

Milestone: -

@hoyosjs
Copy link
Member

hoyosjs commented Aug 30, 2021

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please request a code review and once we have a green CI we can merge.

@jeffschwMSFT jeffschwMSFT merged commit 9f6ad57 into release/6.0 Aug 31, 2021
@akoeplinger akoeplinger deleted the backport/pr-58166-to-release/6.0 branch September 9, 2021 11:26
@ghost ghost locked as resolved and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants