[release/6.0] Fix TimeZoneInfo.HasIanaId when using Local Time Zone #58414
Conversation
|
Tagging subscribers to this area: @tarekgh, @safern Issue DetailsFixes #58326 Backport of #58392 to release/6.0 /cc @tarekgh Customer ImpactWithout this fix, users of We have exposed the new property TestingI tested this on Windows and Linux. Also, I have run the whole regression tests with the fix without any problem. I added more tests to cover the test gap for the functionality we are fixing here. RiskIs low. The fix is scoped to the
|
|
Approved for release/6.0. Clear defect in a new API, reported by partner, localized fix. |
|
CC @eerhardt |
|
CC @@roji |
|
@danmoseley could you please merge this one? Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Fixes #58326
Backport of #58392 to release/6.0
/cc @tarekgh
Customer Impact
Without this fix, users of
TimeZoneInfo.HasIanaIdcan get wrong values when usingTimeZoneInfo.Local.We have exposed the new property
TimeZoneInfo.HasIanaIdin .NET 6.0. This property tells if the Time Zone object is created with IANA Id. This property returns the correct results except when usingTimeZoneInfo.Local. The reason is when we initializeTimeZoneInfo.Localproperty we clone the object before returning it, but we missed cloningHasIanaIdproperty inside the returned object. The fix is to ensureHasIanaIdis initialized correctly inTimeZoneInfo.Local.Testing
I tested this on Windows and Linux. Also, I have run the whole regression tests with the fix without any problem. I added more tests to cover the test gap for the functionality we are fixing here.
Risk
Is low. The fix is scoped to the
HasIanaIdproperty only which is a newly exposed property in .NET 6.0. The change is well tested and added more tests too.