-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Enforce scatter/gather file I/O Windows API requirements et. al. #58423
Merged
Commits on Aug 31, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a3b0d18 - Browse repository at this point
Copy the full SHA a3b0d18View commit details -
Refactor the scatter/gather APIs to use the common checking method.
And use pinned GCHandles and IntPtrs instead of MemoryHandles when passing the segment array to the bottom-most method.
Configuration menu - View commit details
-
Copy full SHA for 82bd893 - Browse repository at this point
Copy the full SHA 82bd893View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81973cb - Browse repository at this point
Copy the full SHA 81973cbView commit details -
Directly get the pinned array's address instead of calling GCHandle.A…
…ddrOfPinnedObject.
Configuration menu - View commit details
-
Copy full SHA for c6153f1 - Browse repository at this point
Copy the full SHA c6153f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 203fd52 - Browse repository at this point
Copy the full SHA 203fd52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 322293d - Browse repository at this point
Copy the full SHA 322293dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c5cc76f - Browse repository at this point
Copy the full SHA c5cc76fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8621c02 - Browse repository at this point
Copy the full SHA 8621c02View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd8c2f8 - Browse repository at this point
Copy the full SHA bd8c2f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea35f8b - Browse repository at this point
Copy the full SHA ea35f8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e755e0f - Browse repository at this point
Copy the full SHA e755e0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b1aaf0 - Browse repository at this point
Copy the full SHA 0b1aaf0View commit details
Commits on Oct 18, 2021
-
Follow up on Scatter/Gather API changes (#58447)
* Allocate an array of memory handles only if needed. * Remove an unnecessary variable in the multiple-syscall write gather. * Actually verify the content read by the read scatter operation. * Delay allocating native memory. * Verify that the whole file was read in the scatter/gather test. * Test the case when the scatter/gather buffers are acceptable by the Windows API. * Avoid null pointer dereferences when passing an empty segment array. * Test performing scatter/gather I/O with an empty segment array. Co-authored-by: Stephen Toub <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 77e8f0d - Browse repository at this point
Copy the full SHA 77e8f0dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.