-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't always build source build with ci flag #58457
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to port these changes back into main as well. Same for the portable change that @dseefeld merged yesterday.
@danmoseley should we treat source build work as tell-mode? |
In my mind - yes. This counts as "Infrastructure work necessary to ship". cc @jeffschwMSFT in case he differs. |
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsLocal dev builds should not normally be building source-build with the "ci" flag. The official builds/ci will set this appropriately. This change removes the "ci" flags for source-build.
|
@ViktorHofer - Has all criteria been satisfied? If so please merge. |
Local dev builds should not normally be building source-build with the "ci" flag. The official builds/ci will set this appropriately. This change removes the "ci" flags for source-build.