Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't always build source build with ci flag #58457

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

MichaelSimons
Copy link
Member

Local dev builds should not normally be building source-build with the "ci" flag. The official builds/ci will set this appropriately. This change removes the "ci" flags for source-build.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to port these changes back into main as well. Same for the portable change that @dseefeld merged yesterday.

@ViktorHofer
Copy link
Member

@danmoseley should we treat source build work as tell-mode?

@danmoseley
Copy link
Member

@danmoseley should we treat source build work as tell-mode?

In my mind - yes. This counts as "Infrastructure work necessary to ship". cc @jeffschwMSFT in case he differs.

@ghost
Copy link

ghost commented Aug 31, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Local dev builds should not normally be building source-build with the "ci" flag. The official builds/ci will set this appropriately. This change removes the "ci" flags for source-build.

Author: MichaelSimons
Assignees: dseefeld, ViktorHofer, crummel
Labels:

area-Infrastructure

Milestone: -

@MichaelSimons
Copy link
Member Author

@ViktorHofer - Has all criteria been satisfied? If so please merge.

@ViktorHofer ViktorHofer merged commit 5ad31a8 into dotnet:release/6.0 Sep 1, 2021
@MichaelSimons MichaelSimons deleted the sb-no-ci branch September 1, 2021 13:39
@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants