[release/6.0] Fix X509ChainElementCollection_CopyTo_NonZeroLowerBound_ThrowsIndexOutOfRangeException test on Android #58489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…tOfRangeException test on Android It started to fail because the validity of the MicrosoftDotComSslCertBytes expired on 2021-08-29 22:17:02. Since this test doesn't need to validate a specific expiration time we can just set the VerificationTime on the chain like we do in other tests. Fixes #58416
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsBackport of #58441 to release/6.0 /cc @akoeplinger Customer ImpactTestingRisk
|
marek-safar
approved these changes
Sep 1, 2021
stephentoub
approved these changes
Sep 1, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58441 to release/6.0
/cc @akoeplinger
Customer Impact
None, this just fixes a test failing in CI.
Testing
The test was failing before, now it passes.
Risk
None.