Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages expanding single-file #58557

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

vitek-karas
Copy link
Member

Followup to the discussion on this issue: #53346 (comment)

In some cases if $HOME is not defined the extraction doesn't provide helpful error message. This change improves the errors by exactly specifying what failed. Added a couple of tests for this as well.

@vitek-karas vitek-karas added this to the 7.0.0 milestone Sep 2, 2021
@vitek-karas vitek-karas self-assigned this Sep 2, 2021
@ghost
Copy link

ghost commented Sep 2, 2021

Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Followup to the discussion on this issue: #53346 (comment)

In some cases if $HOME is not defined the extraction doesn't provide helpful error message. This change improves the errors by exactly specifying what failed. Added a couple of tests for this as well.

Author: vitek-karas
Assignees: vitek-karas
Labels:

area-Single-File

Milestone: 7.0.0

}
else
{
trace::error(_X("Failed to determine default extraction location. Environment variable '$HOME' is not defined."));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @am11. There's #58464 which is basically tracking potential improvements in where to put the files. I think using other means to obtain the default location falls into that category as well. I wanted to keep this one very simple, solely as a diagnostics improvement (not changing actual functional behavior).

@vitek-karas
Copy link
Member Author

@VSadov could you please take a look?

Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@vitek-karas vitek-karas merged commit 1517985 into dotnet:main Sep 13, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
@vitek-karas vitek-karas deleted the ExpandDiag branch September 26, 2023 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants