Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Libraries] Fix TimeZoneInfoTests IsIanaIdTest for iOS/MacCatalyst/tvOS #58562

Merged
merged 7 commits into from
Sep 6, 2021
Merged

[Libraries] Fix TimeZoneInfoTests IsIanaIdTest for iOS/MacCatalyst/tvOS #58562

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d7ee4e7
[Libraries] Fix TimeZoneInfoTests IsIanaIdTest for iOS/MacCatalyst/tvOS
Sep 2, 2021
4aa8873
[Libraries] Fix IsIanaIdTest to assert throw for iOS/MacCatalyst/tvOS
Sep 2, 2021
471ddd9
Readd new line
Sep 2, 2021
a7c9291
[Mobile][Libraries] System.Runtime.Tests TimeZoneInfoTests remove mob…
Sep 3, 2021
694989e
[libraries] System.Runtime.Tests revert IsIanaIdTest iOS tvOS special…
Sep 3, 2021
20a55b7
Merge remote-tracking branch 'upstream/main' into fix_IsIanaId_iOS_ma…
Sep 3, 2021
67039ab
Remove active issue added in recently merged PR
Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2671,8 +2671,14 @@ public static void IsIanaIdTest()
Assert.True((expected || tzi.Id.Equals("Utc", StringComparison.OrdinalIgnoreCase)) == tzi.HasIanaId, $"`{tzi.Id}` has wrong IANA Id indicator");
}

string timeZoneIdNotIANAId = PlatformDetection.IsiOS || PlatformDetection.IstvOS ? "America/Buenos_Aires" : "Pacific Standard Time";
Assert.False(TimeZoneInfo.FindSystemTimeZoneById(timeZoneIdNotIANAId).HasIanaId, $" should not be IANA Id.");
if (!PlatformDetection.IsiOS && !PlatformDetection.IstvOS)
{
Assert.False(TimeZoneInfo.FindSystemTimeZoneById("Pacific Standard Time").HasIanaId, $" should not be IANA Id.");
}
else
{
Assert.Throws<TimeZoneNotFoundException>(() => TimeZoneInfo.FindSystemTimeZoneById("Pacific Standard Time").HasIanaId);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HasIanaId

nit: Maybe you don't need calling this property here? it wouldn't hurt if you keep it though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking similarly since it is unnecessary, but was wondering if keeping the HasIanaId would be in the spirit of the test purpose of checking if it was Iana Id.

}
Assert.True(TimeZoneInfo.FindSystemTimeZoneById("America/Los_Angeles").HasIanaId, $"'America/Los_Angeles' should be IANA Id");
}

Expand Down