[release/6.0] Fix crossgen2 calli GC hole by unifying MethodDesc/MethodSignature IsMarshallingRequired logic #58609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
For unmanaged calli crossgen2 was not properly checking all necessary conditions for a pinvoke being required. In particular it did not check for managed byrefs. Unify the MethodDesc/MethodSignature logic to get all the checks. Fix #58259
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsBackport of #58430 to release/6.0 /cc @jakobbotsch Customer ImpactTestingRisk
|
|
cc @jeffschwMSFT for backport to 6.0. |
jeffschwMSFT
approved these changes
Sep 3, 2021
davidwrighton
approved these changes
Sep 3, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58430 to release/6.0
/cc @jakobbotsch
Customer Impact
Crossgenning code that uses unmanaged function pointers with managed references may lead to codegen that does not pin those references around the unmanaged call. This leads to GC holes/memory corruption.
Testing
There is a regression test included. The test case asserts before this change because the JIT is confused about the passing of a byref to an unmanaged call.
Risk
Low, this unifies the existing correct pinvoke check (used for standard pinvoke) with the one used for unmanaged function pointers (that was incorrect).