[release/6.0] Support JsonConverterFactory with src-gen #58652
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
eiriktsarpalis,
layomia and
steveharter
as code owners
|
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsBackport of #58398 to release/6.0 /cc @steveharter Customer ImpactTestingRisk
|
|
cc @danmoseley |
There was a problem hiding this comment.
LGTM, source/generated code changes are sound; test coverage is robust and addresses this core scenario (JsonConverterFactory + src-gen) for 6.0. cc @danmoseley
|
Given the churn and that it's arguably a documentable limitation, I doubt this would make the RC2 bar (starting 9/14). But I'm OK taking this now as it will increase adoption of this new feature. As discussed offline, I appreciate the comprehensive tests but since there's significant churn here I would prefer to get another pair of eyes reviewing it before merging. |
|
Oh, I see @layomia did that. OK, we can merge when green. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #58398 to release/6.0
/cc @steveharter
Customer Impact
Support for
JsonConverterFactoryis currently broken in source generators. It has the potential to block customers from migrating existing reflection-based serialization DTOs to source gen.Testing
Added testing that validate the broken scenaria.
Risk
Low to moderate. Accommodating factories requires a moderate amount of refactoring in product code.