Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0] Replace S.S.Permissions ref with AccessControl in S.S.C.Xml #58666

Merged
merged 1 commit into from
Sep 4, 2021
Merged

[release/6.0] Replace S.S.Permissions ref with AccessControl in S.S.C.Xml #58666

merged 1 commit into from
Sep 4, 2021

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Sep 3, 2021 •
edited
Loading

56894f0 brought the
System.Security.AccessControl library and package back but
in the change, the reference in System.Security.Cryptography.Xml
to System.Security.Permissions wasn't replaced with the reference
to System.Security.AccessControl.

Discovered by @ericstj here: #57816 (comment).

Dependencies section in the nuspec:

    <dependencies>
      <group targetFramework=".NETFramework4.6.1">
        <dependency id="System.Security.AccessControl" version="6.0.0-dev" exclude="Build,Analyzers" />
      </group>
      <group targetFramework="net6.0">
        <dependency id="System.Security.AccessControl" version="6.0.0-dev" exclude="Build,Analyzers" />
        <dependency id="System.Security.Cryptography.Pkcs" version="6.0.0-dev" exclude="Build,Analyzers" />
      </group>
      <group targetFramework=".NETStandard2.0">
        <dependency id="System.Security.AccessControl" version="6.0.0-dev" exclude="Build,Analyzers" />
        <dependency id="System.Security.Cryptography.Pkcs" version="6.0.0-dev" exclude="Build,Analyzers" />
        <dependency id="System.Memory" version="4.5.4" exclude="Build,Analyzers" />
      </group>
    </dependencies>

@ViktorHofer
Replace S.S.Permissions ref with AccessControl in S.S.C.Xml
9511d98 
56894f0 brought the
System.Security.AccessControl library and package back but
in the change, the reference in System.Security.Cryptography.Xml
to System.Security.Permissions wasn't replaced with the reference
to System.Security.AccessControl.
@ViktorHofer ViktorHofer added this to the 6.0.0 milestone Sep 3, 2021
@ViktorHofer ViktorHofer self-assigned this Sep 3, 2021
@ghost
Copy link

ghost commented Sep 3, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

56894f0 brought the
System.Security.AccessControl library and package back but
in the change, the reference in System.Security.Cryptography.Xml
to System.Security.Permissions wasn't replaced with the reference
to System.Security.AccessControl.

Dependencies section in the nuspec:

    <dependencies>
      <group targetFramework=".NETFramework4.6.1">
        <dependency id="System.Security.AccessControl" version="6.0.0-dev" exclude="Build,Analyzers" />
      </group>
      <group targetFramework="net6.0">
        <dependency id="System.Security.AccessControl" version="6.0.0-dev" exclude="Build,Analyzers" />
        <dependency id="System.Security.Cryptography.Pkcs" version="6.0.0-dev" exclude="Build,Analyzers" />
      </group>
      <group targetFramework=".NETStandard2.0">
        <dependency id="System.Security.AccessControl" version="6.0.0-dev" exclude="Build,Analyzers" />
        <dependency id="System.Security.Cryptography.Pkcs" version="6.0.0-dev" exclude="Build,Analyzers" />
        <dependency id="System.Memory" version="4.5.4" exclude="Build,Analyzers" />
      </group>
    </dependencies>
Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries
Milestone: 6.0.0

@ViktorHofer ViktorHofer changed the title Replace S.S.Permissions ref with AccessControl in S.S.C.Xml [release/6.0] Replace S.S.Permissions ref with AccessControl in S.S.C.Xml Sep 3, 2021
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Sep 3, 2021 •
edited
Loading

@danmoseley unfortunately I missed this in #57816. Should I again add a servicing template or can we treat this as follow-up?

@danmoseley
Copy link
Member

We can skip the template for this one.

Can you think of any other places we might have similar issues or other checks we should make?

Assuming so -- approved -- necessary fix to a change that would still meet the bar.

@danmoseley danmoseley added the Servicing-approved Approved for servicing release label Sep 3, 2021
ericstj
ericstj approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirmed this was the only one that needed it

@dougbu dougbu mentioned this pull request Sep 3, 2021
Merged
@ViktorHofer ViktorHofer merged commit b7e72a4 into dotnet:release/6.0 Sep 4, 2021
@ViktorHofer ViktorHofer deleted the FixCryptoXmlReferenceToPermissions branch September 4, 2021 08:43
@dougbu dougbu mentioned this pull request Sep 6, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericstj ericstj ericstj approved these changes

@Anipik Anipik Anipik approved these changes

Assignees

@ViktorHofer ViktorHofer

Labels
area-Infrastructure-libraries Servicing-approved Approved for servicing release
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ViktorHofer @danmoseley @ericstj @Anipik