-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] add TLS 1.3 support to WinHttp #58718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending green CI & manual Win11 verification.
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Unrelated infra problems:
@dotnet/dncenghot is it a known infra problem? Re-running tests ... |
It is on |
all these failures happened on |
I haven't but this is not related to Apple/Android so I wouldn't know. There were some issues around OSX machines getting their jobs killed - https://github.com/dotnet/core-eng/issues/14085 |
I see, I will raise ticket for DDFUN to fix that machine then |
On re-run we got 3 different test suites stuck on the same machine Given all the above, the CI results should be considered passing. |
Approved - localized, low risk change to fix mainstream scenario regressing on Windows 11. |
Yes, we plan to run Win11 manually -- I actually wanted to make it testing prereq prior to merging (as todo in top post suggests), but I forgot about it and pinged you for approval prematurely ;( ... sorry for that! |
Backport of #58590 to release/6.0
WinHttp now has and the flag and it seems to work right on Windows 11
.NET Framework 4.8 now supports Tls13 as well somebody can use it with casting
int
like the test change.It really does not matter as long as running on supported OS and WinHttp as all the work is done by native code.
Fixes #58587
/cc @karelz @wfurt
Customer Impact
Users of WinHttpHandler cannot use TLS1.3 on Win11+ (where the OS supports it).
We would need to release WinHttpHandler NuGet package patch (via servicing of .NET 6) once Win11 is public.
Testing
TODO: Win11 test run - @wfurt
Risk
Low. The component only sim-ships with .NET 6 as a standalone NuGet package.
The change only sets a flag on WinHttp (if it is supported).