Avoid S.S.Permissions dependency in S.S.Crypto.Xml #58731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid the S.S.Permissions dependency by referencing the latest available System.Security.AccessControl package which contans the Evidence types in all tfms in the System.Security.Cryptography.Xml project. Add suppression file for Permissions
ViktorHofer
force-pushed
the
SystemSecurityPermissionsAvoid
branch
from
17069f7
to
bfbcb09
Compare
ericstj
approved these changes
Sep 7, 2021
| @@ -103,7 +103,7 @@ | |||
| <SystemRuntimeInteropServicesVersion>4.3.0</SystemRuntimeInteropServicesVersion> | |||
| <SystemRuntimeInteropServicesRuntimeInformationVersion>4.3.0</SystemRuntimeInteropServicesRuntimeInformationVersion> | |||
| <SystemRuntimeSerializationPrimitivesVersion>4.3.0</SystemRuntimeSerializationPrimitivesVersion> | |||
| <SystemSecurityAccessControlVersion>5.0.0</SystemSecurityAccessControlVersion> | |||
| <SystemSecurityAccessControlVersion>6.0.0-rc.2.21454.1</SystemSecurityAccessControlVersion> | |||
There was a problem hiding this comment.
This is OK for now, but we should make sure to remember to update to 6.0.0 stable when available.
There was a problem hiding this comment.
One other place that might be interesting to pick up 6.0.0 prerelease is here:
|
Failures are:
|
|
I need to wait for a successful dotnet-runtime-official build and a merged dependency update PR in dotnet/aspnetcore before I can put up a reaction PR. Looks like that pipeline hasn't passed in the last few builds. Watching… |
|
My arcade changes for ARM64 broke official build and should be fixed with dotnet/arcade#7845 |
dougbu
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Sep 10, 2021
- `cherry-pick` e58a6c2 - see dotnet/runtime#57816 (comment) - also reacting to dotnet/runtime#58731 - undo much of 18a61fb
dougbu
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Sep 22, 2021
- `cherry-pick` e58a6c2 - see dotnet/runtime#57816 (comment) - also reacting to dotnet/runtime#58731 - undo much of 18a61fb
dougbu
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Sep 23, 2021
* [main] React to dotnet/runtime#57816 (#36155) - `cherry-pick` e58a6c2 - see dotnet/runtime#57816 (comment) - also reacting to dotnet/runtime#58731 - undo much of 18a61fb * [main] Cleanup remaining SSP references (#36248) - `cherry-pick` 888e03a - remove references to System.Security.Permissions and its closure - only mentions are in eng/PackageOverrides.txt and eng/PlatformManifest.txt - those files will remain unused until we update them in the run-up to 6.0.1 - may see some package refs for SSP and its closure elsewhere but this does not impact targeting pack content - also remove duplication between `@(AspNetCoreReferenceAssemblyPath)` additions (for efficiency) nit: Only need to exclude System.Net.Quic from `@(_AvailableRuntimeRefAssemblies)` - Crypto.Pkcs is **not** present in the transport package - other disallowed entries aren't present in the transport package or our dependency closure
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the S.S.Permissions dependency by referencing the
latest available System.Security.AccessControl package
which contans the Evidence types in all tfms in the
System.Security.Cryptography.Xml project.
FYI @dougbu that's the accompanying change to avoid
the System.Security.Permissions dependency in main.