Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Net.Ping: Skip TimeoutIsRespected test if network is unreachable #58745

Merged
merged 1 commit into from
Sep 9, 2021

Commits on Sep 7, 2021

  1. System.Net.Ping: Skip TimeoutIsRespected test if network is unreachable

    The TestSettings.UnreachableAddress is using 192.0.2.0 which is documented in RFC5735 as a network to be used in docs/example code.
    On the Android devices in Helix the upstream network is configured to not route this address which results in a "Destination Net Unreachable" response
    which causes the timeout argument to ping to be ignored and ping returns immediately.
    Skip the test in these cases.
    
    Example output from ping on the device:
    
    ```
    1|sunfish:/ $ time ping -c 1 -W 2 -s 50 192.0.2.0
    PING 192.0.2.0 (192.0.2.0) 50(78) bytes of data.
    From 131.107.5.118: icmp_seq=1 Destination Net Unreachable
    
    --- 192.0.2.0 ping statistics ---
    1 packets transmitted, 0 received, +1 errors, 100% packet loss, time Oms
    
       0m00.03s real   0m00.00s user   0m00.00s system
    ```
    akoeplinger committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    fcca1d5 View commit details
    Browse the repository at this point in the history