Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use separate VNs for DBL2INT_OVF helpers #58868

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Use separate VNs for DBL2INT_OVF helpers #58868

merged 2 commits into from
Sep 10, 2021

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Sep 9, 2021

Fixes #58832

I don't think it makes much sense to share VNs between OVF and non-OVF helpers in terms of performance.

/cc @SingleAccretion feel free to rewrite it to VNForCast for 7.0

SPMI-diffs (only caught ValueNumberingCheckedCastsOfConstants test where such cases are tested):

coreclr_tests.pmi.windows.x64.checked.mch:


Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 60315
Total bytes of diff: 61016
Total bytes of delta: 701 (1.16% of base)
Total relative delta: 1.28
    diff is a regression.
    relative diff is a regression.
Detail diffs 


Top file regressions (bytes):
           7 : 3747.dasm (1.26% of base)
           7 : 3752.dasm (1.26% of base)
           7 : 4449.dasm (1.26% of base)
           7 : 4466.dasm (1.29% of base)
           7 : 3743.dasm (1.26% of base)
           7 : 3751.dasm (1.26% of base)
           7 : 3851.dasm (1.29% of base)
           7 : 4450.dasm (1.26% of base)
           7 : 4468.dasm (1.29% of base)
           7 : 3742.dasm (1.28% of base)
           7 : 4398.dasm (1.26% of base)
           7 : 4516.dasm (1.28% of base)
           7 : 3738.dasm (1.28% of base)
           7 : 3799.dasm (1.28% of base)
           7 : 4440.dasm (1.28% of base)
           7 : 3748.dasm (1.26% of base)
           7 : 3797.dasm (1.28% of base)
           7 : 3809.dasm (1.28% of base)
           7 : 4447.dasm (1.28% of base)
           7 : 4463.dasm (1.28% of base)

110 total files with Code Size differences (0 improved, 110 regressed), 0 unchanged.

Top method regressions (bytes):
           7 ( 1.29% of base) : 3851.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleMinusZeroCastToUInt64IsFoldedCorrectly|19_1()
           7 ( 1.29% of base) : 3806.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneDecrementUnderByteMinValueCastToUInt64IsFoldedCorrectly|19_20()
           7 ( 1.26% of base) : 3747.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneDecrementUnderInt64MaxValueCastToUInt64IsFoldedCorrectly|19_77()
           7 ( 1.28% of base) : 3797.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneDecrementUnderSByteMaxValueCastToUInt64IsFoldedCorrectly|19_11()
           7 ( 1.28% of base) : 3738.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneDecrementUnderUInt32MaxValueCastToUInt64IsFoldedCorrectly|19_68()
           7 ( 1.28% of base) : 3798.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneFullDecrementUnderSByteMaxValueCastToUInt64IsFoldedCorrectly|19_12()
           7 ( 1.28% of base) : 3739.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneFullDecrementUnderUInt32MaxValueCastToUInt64IsFoldedCorrectly|19_69()
           7 ( 1.28% of base) : 3809.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneFullIncrementAboveByteMinValueCastToUInt64IsFoldedCorrectly|19_23()
           7 ( 1.28% of base) : 3784.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneFullIncrementAboveInt32MaxValueCastToUInt64IsFoldedCorrectly|19_62()
           7 ( 1.26% of base) : 3749.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneFullIncrementAboveInt64MaxValueCastToUInt64IsFoldedCorrectly|19_79()
           7 ( 1.26% of base) : 3741.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneFullIncrementAboveUInt32MaxValueCastToUInt64IsFoldedCorrectly|19_71()
           7 ( 1.29% of base) : 3808.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneIncrementAboveByteMinValueCastToUInt64IsFoldedCorrectly|19_22()
           7 ( 1.26% of base) : 3748.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneIncrementAboveInt64MaxValueCastToUInt64IsFoldedCorrectly|19_78()
           7 ( 1.28% of base) : 3799.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneIncrementAboveSByteMaxValueCastToUInt64IsFoldedCorrectly|19_13()
           7 ( 1.28% of base) : 3740.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneIncrementAboveUInt32MaxValueCastToUInt64IsFoldedCorrectly|19_70()
           7 ( 1.26% of base) : 3745.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmInt64MaxValueCastToUInt64IsFoldedCorrectly|19_75()
           7 ( 1.26% of base) : 3751.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmIntegerOneDecrementUnderInt64MaxValueCastToUInt64IsFoldedCorrectly|19_81()
           7 ( 1.28% of base) : 3803.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmIntegerOneDecrementUnderSByteMaxValueCastToUInt64IsFoldedCorrectly|19_17()
           7 ( 1.28% of base) : 3742.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmIntegerOneDecrementUnderUInt32MaxValueCastToUInt64IsFoldedCorrectly|19_72()
           7 ( 1.28% of base) : 3815.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmIntegerOneIncrementAboveByteMinValueCastToUInt64IsFoldedCorrectly|19_29()

Top method regressions (percentages):
           7 ( 1.29% of base) : 3851.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleMinusZeroCastToUInt64IsFoldedCorrectly|19_1()
           7 ( 1.29% of base) : 3806.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneDecrementUnderByteMinValueCastToUInt64IsFoldedCorrectly|19_20()
           7 ( 1.29% of base) : 3808.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneIncrementAboveByteMinValueCastToUInt64IsFoldedCorrectly|19_22()
           7 ( 1.29% of base) : 4509.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmFloatMinusZeroCastToUInt64IsFoldedCorrectly|11_1()
           7 ( 1.29% of base) : 4466.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmSingleOneDecrementUnderByteMinValueCastToUInt64IsFoldedCorrectly|11_22()
           7 ( 1.29% of base) : 4468.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmSingleOneIncrementAboveByteMinValueCastToUInt64IsFoldedCorrectly|11_24()
           7 ( 1.28% of base) : 3797.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneDecrementUnderSByteMaxValueCastToUInt64IsFoldedCorrectly|19_11()
           7 ( 1.28% of base) : 3798.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneFullDecrementUnderSByteMaxValueCastToUInt64IsFoldedCorrectly|19_12()
           7 ( 1.28% of base) : 3809.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneFullIncrementAboveByteMinValueCastToUInt64IsFoldedCorrectly|19_23()
           7 ( 1.28% of base) : 3799.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneIncrementAboveSByteMaxValueCastToUInt64IsFoldedCorrectly|19_13()
           7 ( 1.28% of base) : 3803.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmIntegerOneDecrementUnderSByteMaxValueCastToUInt64IsFoldedCorrectly|19_17()
           7 ( 1.28% of base) : 3815.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmIntegerOneIncrementAboveByteMinValueCastToUInt64IsFoldedCorrectly|19_29()
           7 ( 1.28% of base) : 3792.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmSByteMaxValueCastToUInt64IsFoldedCorrectly|19_6()
           7 ( 1.28% of base) : 4463.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmIntegerOneDecrementUnderSByteMaxValueCastToUInt64IsFoldedCorrectly|11_19()
           7 ( 1.28% of base) : 4475.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmIntegerOneIncrementAboveByteMinValueCastToUInt64IsFoldedCorrectly|11_31()
           7 ( 1.28% of base) : 4516.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmSByteMaxValueCastToUInt64IsFoldedCorrectly|11_8()
           7 ( 1.28% of base) : 4521.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmSingleOneDecrementUnderSByteMaxValueCastToUInt64IsFoldedCorrectly|11_13()
           7 ( 1.28% of base) : 4522.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmSingleOneFullDecrementUnderSByteMaxValueCastToUInt64IsFoldedCorrectly|11_14()
           7 ( 1.28% of base) : 4469.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmSingleOneFullIncrementAboveByteMinValueCastToUInt64IsFoldedCorrectly|11_25()
           7 ( 1.28% of base) : 4523.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmSingleOneIncrementAboveSByteMaxValueCastToUInt64IsFoldedCorrectly|11_15()

110 total methods with Code Size differences (0 improved, 110 regressed), 0 unchanged.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 9, 2021
@ghost
Copy link

ghost commented Sep 9, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #58832

I don't think it makes much sense to share VNs between OVF and non-OVF helpers in terms of performance.

/cc @SingleAccretion feel free to rewrite it to VNForCast for 7.0

SPMI-diffs (only caught ValueNumberingCheckedCastsOfConstants test where such cases are tested):

coreclr_tests.pmi.windows.x64.checked.mch:


Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 60315
Total bytes of diff: 61016
Total bytes of delta: 701 (1.16% of base)
Total relative delta: 1.28
    diff is a regression.
    relative diff is a regression.
Detail diffs 


Top file regressions (bytes):
           7 : 3747.dasm (1.26% of base)
           7 : 3752.dasm (1.26% of base)
           7 : 4449.dasm (1.26% of base)
           7 : 4466.dasm (1.29% of base)
           7 : 3743.dasm (1.26% of base)
           7 : 3751.dasm (1.26% of base)
           7 : 3851.dasm (1.29% of base)
           7 : 4450.dasm (1.26% of base)
           7 : 4468.dasm (1.29% of base)
           7 : 3742.dasm (1.28% of base)
           7 : 4398.dasm (1.26% of base)
           7 : 4516.dasm (1.28% of base)
           7 : 3738.dasm (1.28% of base)
           7 : 3799.dasm (1.28% of base)
           7 : 4440.dasm (1.28% of base)
           7 : 3748.dasm (1.26% of base)
           7 : 3797.dasm (1.28% of base)
           7 : 3809.dasm (1.28% of base)
           7 : 4447.dasm (1.28% of base)
           7 : 4463.dasm (1.28% of base)

110 total files with Code Size differences (0 improved, 110 regressed), 0 unchanged.

Top method regressions (bytes):
           7 ( 1.29% of base) : 3851.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleMinusZeroCastToUInt64IsFoldedCorrectly|19_1()
           7 ( 1.29% of base) : 3806.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneDecrementUnderByteMinValueCastToUInt64IsFoldedCorrectly|19_20()
           7 ( 1.26% of base) : 3747.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneDecrementUnderInt64MaxValueCastToUInt64IsFoldedCorrectly|19_77()
           7 ( 1.28% of base) : 3797.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneDecrementUnderSByteMaxValueCastToUInt64IsFoldedCorrectly|19_11()
           7 ( 1.28% of base) : 3738.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneDecrementUnderUInt32MaxValueCastToUInt64IsFoldedCorrectly|19_68()
           7 ( 1.28% of base) : 3798.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneFullDecrementUnderSByteMaxValueCastToUInt64IsFoldedCorrectly|19_12()
           7 ( 1.28% of base) : 3739.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneFullDecrementUnderUInt32MaxValueCastToUInt64IsFoldedCorrectly|19_69()
           7 ( 1.28% of base) : 3809.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneFullIncrementAboveByteMinValueCastToUInt64IsFoldedCorrectly|19_23()
           7 ( 1.28% of base) : 3784.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneFullIncrementAboveInt32MaxValueCastToUInt64IsFoldedCorrectly|19_62()
           7 ( 1.26% of base) : 3749.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneFullIncrementAboveInt64MaxValueCastToUInt64IsFoldedCorrectly|19_79()
           7 ( 1.26% of base) : 3741.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneFullIncrementAboveUInt32MaxValueCastToUInt64IsFoldedCorrectly|19_71()
           7 ( 1.29% of base) : 3808.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneIncrementAboveByteMinValueCastToUInt64IsFoldedCorrectly|19_22()
           7 ( 1.26% of base) : 3748.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneIncrementAboveInt64MaxValueCastToUInt64IsFoldedCorrectly|19_78()
           7 ( 1.28% of base) : 3799.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneIncrementAboveSByteMaxValueCastToUInt64IsFoldedCorrectly|19_13()
           7 ( 1.28% of base) : 3740.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneIncrementAboveUInt32MaxValueCastToUInt64IsFoldedCorrectly|19_70()
           7 ( 1.26% of base) : 3745.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmInt64MaxValueCastToUInt64IsFoldedCorrectly|19_75()
           7 ( 1.26% of base) : 3751.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmIntegerOneDecrementUnderInt64MaxValueCastToUInt64IsFoldedCorrectly|19_81()
           7 ( 1.28% of base) : 3803.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmIntegerOneDecrementUnderSByteMaxValueCastToUInt64IsFoldedCorrectly|19_17()
           7 ( 1.28% of base) : 3742.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmIntegerOneDecrementUnderUInt32MaxValueCastToUInt64IsFoldedCorrectly|19_72()
           7 ( 1.28% of base) : 3815.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmIntegerOneIncrementAboveByteMinValueCastToUInt64IsFoldedCorrectly|19_29()

Top method regressions (percentages):
           7 ( 1.29% of base) : 3851.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleMinusZeroCastToUInt64IsFoldedCorrectly|19_1()
           7 ( 1.29% of base) : 3806.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneDecrementUnderByteMinValueCastToUInt64IsFoldedCorrectly|19_20()
           7 ( 1.29% of base) : 3808.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneIncrementAboveByteMinValueCastToUInt64IsFoldedCorrectly|19_22()
           7 ( 1.29% of base) : 4509.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmFloatMinusZeroCastToUInt64IsFoldedCorrectly|11_1()
           7 ( 1.29% of base) : 4466.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmSingleOneDecrementUnderByteMinValueCastToUInt64IsFoldedCorrectly|11_22()
           7 ( 1.29% of base) : 4468.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmSingleOneIncrementAboveByteMinValueCastToUInt64IsFoldedCorrectly|11_24()
           7 ( 1.28% of base) : 3797.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneDecrementUnderSByteMaxValueCastToUInt64IsFoldedCorrectly|19_11()
           7 ( 1.28% of base) : 3798.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneFullDecrementUnderSByteMaxValueCastToUInt64IsFoldedCorrectly|19_12()
           7 ( 1.28% of base) : 3809.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneFullIncrementAboveByteMinValueCastToUInt64IsFoldedCorrectly|19_23()
           7 ( 1.28% of base) : 3799.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmDoubleOneIncrementAboveSByteMaxValueCastToUInt64IsFoldedCorrectly|19_13()
           7 ( 1.28% of base) : 3803.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmIntegerOneDecrementUnderSByteMaxValueCastToUInt64IsFoldedCorrectly|19_17()
           7 ( 1.28% of base) : 3815.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmIntegerOneIncrementAboveByteMinValueCastToUInt64IsFoldedCorrectly|19_29()
           7 ( 1.28% of base) : 3792.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingDoubleToUInt64>g__ConfirmSByteMaxValueCastToUInt64IsFoldedCorrectly|19_6()
           7 ( 1.28% of base) : 4463.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmIntegerOneDecrementUnderSByteMaxValueCastToUInt64IsFoldedCorrectly|11_19()
           7 ( 1.28% of base) : 4475.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmIntegerOneIncrementAboveByteMinValueCastToUInt64IsFoldedCorrectly|11_31()
           7 ( 1.28% of base) : 4516.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmSByteMaxValueCastToUInt64IsFoldedCorrectly|11_8()
           7 ( 1.28% of base) : 4521.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmSingleOneDecrementUnderSByteMaxValueCastToUInt64IsFoldedCorrectly|11_13()
           7 ( 1.28% of base) : 4522.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmSingleOneFullDecrementUnderSByteMaxValueCastToUInt64IsFoldedCorrectly|11_14()
           7 ( 1.28% of base) : 4469.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmSingleOneFullIncrementAboveByteMinValueCastToUInt64IsFoldedCorrectly|11_25()
           7 ( 1.28% of base) : 4523.dasm - ValueNumberingCheckedCastsOfConstants:<TestCastingSingleToUInt64>g__ConfirmSingleOneIncrementAboveSByteMaxValueCastToUInt64IsFoldedCorrectly|11_15()

110 total methods with Code Size differences (0 improved, 110 regressed), 0 unchanged.
Author: EgorBo
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@JulieLeeMSFT JulieLeeMSFT added this to the 6.0.0 milestone Sep 9, 2021
@JulieLeeMSFT
Copy link
Member

CC @AndyAyersMS please review this PR targetting .NET6 port.

@EgorBo EgorBo merged commit df6e28e into dotnet:main Sep 10, 2021
@EgorBo
Copy link
Member Author

EgorBo commented Sep 10, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1220945364

@github-actions github-actions bot mentioned this pull request Sep 10, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

FltToInt: OverflowException in Debug and no exception in Release
3 participants
@EgorBo @JulieLeeMSFT @AndyAyersMS