[release/6.0] Consider finally that jumps to itself as non-empty #58881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsBackport of #58771 to release/6.0 /cc @kunalspathak Customer ImpactTestingRisk
|
|
CC @jeffschwMSFT for 6.0 backport. |
|
Please fill in the customer impact and request a code review. |
|
@AndyAyersMS , @dotnet/jit-contrib |
|
Did you look at what happens in release if we don't fix this issue? |
In release it works as expected, but it wrongly sets the |
|
I agree this is very low risk, so I'm ok with us porting it. |
AndyAyersMS
approved these changes
Sep 10, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58771 to release/6.0
/cc @kunalspathak
Customer Impact
If there is an infinite loop inside finally, we will not cleanly remove the unreachable blocks inside finally clause.
Testing
The change was locally tested. I didn't add explicit test because the repro needed an infinite loop.
Risk
Low - The change will conservatively skip removing a non-empty finally clause.