[release/6.0] [tasks] [net472] Add ProjectReferences to JsonToItemsTaskFactory #58917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Reference the same versions of System.Threding.Tasks.Extensions and System.Text.Json that MSBuild in Visual Studio 2022 uses. Fixes build errors on maui-ios (and possibly blazorwasm) targets on Windows like: ``` System.MissingMethodException: Method not found: 'System.Threading.Tasks.ValueTask`1<!!0> System.Text.Json.JsonSerializer.DeserializeAsync(System.IO.Stream, System.Text.Json.JsonSerializerOptions, System.Threading.CancellationToken)'. at JsonToItemsTaskFactory.JsonToItemsTaskFactory.JsonToItemsTask.<GetJsonAsync>d__24.MoveNext() at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.Start[TStateMachine](TStateMachine& stateMachine) at JsonToItemsTaskFactory.JsonToItemsTaskFactory.JsonToItemsTask.GetJsonAsync(String jsonFilePath, FileStream file) at JsonToItemsTaskFactory.JsonToItemsTaskFactory.JsonToItemsTask.TryGetJson(String jsonFilePath, JsonModelRoot& json) at JsonToItemsTaskFactory.JsonToItemsTaskFactory.JsonToItemsTask.Execute() at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() ``` from `C:\Program Files\dotnet\packs\Microsoft.NET.Runtime.MonoTargets.Sdk\6.0.0-rc.1.21451.13\Sdk\RuntimeComponentManifest.targets`
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
lambdageek
approved these changes
Sep 10, 2021
marek-safar
approved these changes
Sep 10, 2021
|
Tagging subscribers to this area: @directhex Issue DetailsBackport of #58825 to release/6.0 /cc @lambdageek Customer ImpactBuilding MAUI or WebAssembly projects from Visual Studio or using TestingManual testing RiskLow. The change is just bumping our task to bundle the same (newer) versions of System.Text.Json and System.Threading.Tasks.Extensions that already ship with MSBuild instead of older ones that require a binding redirect. As a workaround
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58825 to release/6.0
/cc @lambdageek
Customer Impact
Building MAUI or WebAssembly projects from Visual Studio or using
msbuildfrom the commandline may fail with aMissingMethodException.Testing
Manual testing
Risk
Low. The change is just bumping our task to bundle the same (newer) versions of System.Text.Json and System.Threading.Tasks.Extensions that already ship with MSBuild instead of older ones that require a binding redirect.
As a workaround
dotnet buildworks. Alternately the binding redirect for the MSBuild executable bundled with Visual Studio may be updated as detailed in dotnet/msbuild#6830