[release/6.0] Throw on unsupported types in src gen #58983
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
eiriktsarpalis,
layomia and
steveharter
as code owners
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
dotnet-issue-labeler
bot
added
area-System.Text.Json
new-api-needs-documentation
labels
|
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsBackport of #58775 to release/6.0 /cc @eiriktsarpalis @steveharter Customer ImpactTestingRisk
|
|
cc @danmoseley |
| @@ -341,7 +341,7 @@ public string PropertyPath() | |||
| static void AppendStackFrame(StringBuilder sb, ref WriteStackFrame frame) | |||
| { | |||
| // Append the property name. | |||
| string? propertyName = frame.DeclaredJsonPropertyInfo?.MemberInfo?.Name; | |||
| string? propertyName = frame.DeclaredJsonPropertyInfo?.ClrName; | |||
There was a problem hiding this comment.
is this a functional change for the non-generator scenario?
|
Approved. Fixes fairly mainstream scenario in this new feature. Code change essentially limited to generators. |
|
If we consider future fixes to the generator, it would reduce risk if it was possible to make zero changes to the non generator codepaths. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #58775 to release/6.0
/cc @eiriktsarpalis @steveharter
Customer Impact
Types unsupported by sourcegen are currently being silently serialized (typically as
{}). This can result in invalid data accidentally being returned in API responses or written to databases.Testing
Tests have been added affirming the new throwing behavior.
Risk
Low. While this is adding more code to the sourcegen implementation, these additions are relatively small and straightforward.