Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Src gen: use GetBestTypeByMetadataName instead of GetTypeByMetadataName #59092
Src gen: use GetBestTypeByMetadataName instead of GetTypeByMetadataName #59092
Changes from all commits
28db0c6
25dcab8
ff67850
a3e6eb1
9c89de0
46b3905
051ed1b
4d6c7a3
7a4eee9
8e2ca47
e1ac8d8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you shouldn't need a new group for this, the exclusions 4 lines above should be enough but it looks like the paths are incorrect? I see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous section (
Condition="'$(TargetsMobile)' == 'true' and '$(TargetOS)' != 'Browser'"
) also excludes the same tests.I obtained the conditions from #54833 which is per #51961 (but for System.Text.Json).
The paths appear correct to me and are consistent with other references to them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't the path start with
Microsoft.Extensions.Logging.Abstractions\tests
notMicrosoft.Extensions.Logging\tests
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes thanks. Missed that.
@eerhardt it looks like the test exclusion added in 9035d94 has the wrong path. I left it as-is in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since it's pointing at the wrong path and passing those old exclusions can probably be removed. I'll do it in a separate pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW Eric fixed that in #59608