Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid resetting gen0 bricks for background_sweep #59106

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Avoid resetting gen0 bricks for background_sweep #59106

merged 1 commit into from
Sep 29, 2021

Conversation

cshung
Copy link
Member

@cshung cshung commented Sep 14, 2021

This is an attempt to make subsequent find_first_object faster after a background_sweep call.

@ghost
Copy link

ghost commented Sep 14, 2021

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

This is an attempt to make subsequent find_first_object faster after a background_sweep call.

Author: cshung
Assignees: -
Labels:

area-GC-coreclr
Milestone: -

Maoni0
Maoni0 approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, this is fine to check into the 7.0 branch so we also get some testing here but we should continue our private stress testing offline.

@cshung cshung changed the title [WIP] Avoid resetting gen0 bricks for background_sweep Avoid resetting gen0 bricks for background_sweep Sep 29, 2021
@cshung cshung merged commit 32a976b into dotnet:main Sep 29, 2021
@cshung cshung deleted the public/optimize_brick branch September 29, 2021 23:44
@cshung
Copy link
Member Author

cshung commented Oct 4, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2021

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1304875264

@github-actions github-actions bot mentioned this pull request Oct 4, 2021
Closed
cshung added a commit to cshung/runtime that referenced this pull request Oct 4, 2021
@cshung
Avoid resetting gen0 bricks for background_sweep (dotnet#59106)
9e82359
@cshung cshung mentioned this pull request Oct 5, 2021
Merged
Anipik pushed a commit that referenced this pull request Oct 5, 2021
@cshung
Avoid resetting gen0 bricks for background_sweep (#59106) (#59960)
5e06d80
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Maoni0 Maoni0 Maoni0 approved these changes

Assignees
No one assigned
Labels
area-GC-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cshung @Maoni0