[release/6.0] WasmAppBuilder: publish only once per target framework instead of invoking publish explicitly. #59136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
approved these changes
Sep 15, 2021
|
After the validation completes of course. Thanks for fixing.. |
|
I'm hoping that this fixes it! |
.. explcitly invoking `Publish`. Based on @ericstj's suggestion dotnet#58816 (comment) . Fixes dotnet#58816 .
radical
force-pushed
the
fix-wasmappbuilder-6.0
branch
from
a01d479
to
4d2eab4
Compare
radical
changed the title
radical
changed the title
marek-safar
approved these changes
Sep 15, 2021
|
Did this break originally get through PR validation just by bad luck? |
Yeah, race, and it happened to pass for all the builds that time 😬 |
radical
added a commit
to radical/runtime
that referenced
this pull request
Sep 15, 2021
…instead of invoking publish explicitly. (dotnet#59136) (cherry picked from commit 5d03338)
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @ericstj's suggestion
#58816 (comment) .
Fixes #58816 .