[release/6.0] Fix SendAsync from impersonated context with default credentials #59155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #58922 to release/6.0 /cc @danmoseley @wfurt Customer ImpactTestingRisk
|
|
Approved per discussion offline. No need to fill out template. |
karelz
approved these changes
Sep 15, 2021
karelz
changed the title
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58922 to release/6.0
Fixes #58033
As @geoffkizer suggested, this fails because the connection setting is updated only in constructor. Even if options are passed to
HttpHandlerconstructor, we actually createHttpConnectionSettingsfirst and then we updated it.I was originally thinking about updating relevant setters in
HttpHandlerbut I end up updating theCloneAndNormalizeand that seems sufficient. That has benefit that all the logic is still encapsulated inHttpConnectionSettings.This is pretty trivial two line change.
Now, the trouble is testing. Some existing NTLM tests use
HttpListenerand that is problematic because of lack of fine control and general reliance. And we do not have any impersonation tests for HTTP.To solve the first issue, I used NTLM code from
Commonand I added (duplicate?) NTLM/Negotiate test using standard Loopback pattern. If that proves to be stable and working we can possibly remove relianceHttpListenerand clean up rest of the tests. (and get some more coverage for code Kestrel use via reflection (or make that finally public)).To solve the second problem, I moved existing
WindowsIdentityFixturetoTestUtilities. That essentially creates ad hoc account and use that for testing. That seems to require some level of privilege. The existing tests inSystem.Securitydid not have any guard and they seems to run fine in CI. We can possibly updateCanRunImpersonatedTestsif this becomes nuisance. Certainly running tests from elevated shell seems to work fine but I don't know if that is really needed.With that, I added new test to verify that
HttpClientwill open new connection for the impersonated context.And it also verifies that the authenticated identity is different.
/cc @danmoseley @wfurt
Customer Impact
Testing
Risk