[release/6.0-rc2] Undo breaking change compat in GetMethodNativeMap #59231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @tommcdon |
|
cc: @gregg-miskelly |
|
RC2 backport for issue #59109 |
mikem8361
approved these changes
Sep 16, 2021
jeffschwMSFT
approved these changes
Sep 17, 2021
|
Visual Studio debugger team signs off. All of our previously-failing tests now pass again with this fix. |
gregg-miskelly
approved these changes
Sep 17, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts to behavior prior to #57176. An address of 0 used to meant the user wanted to get an offset from the beginning of the method. Now that address is used to calculate the tiered version of the method. If the address is 0, return to the old behavior of getting the default MethodDesc.
Backport of #59114 to release/6.0-rc2
Customer Impact
VS reports. WinDBG also uses this method to provide some aid in Line info support.
Testing
Tested manually. Handed off private to partners to validate fix.
Risk
Low - maintains compat with the old
addr = 0behavior. Non-0 address behavior used to be extremely broken so the 6.0 fix is still correct.