[release/6.0-rc2] Create and publish missing symbols #59259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
imhameed,
lambdageek,
marek-safar,
SamMonoRT and
vargaz
as code owners
lewing
added
Servicing-consider
|
can somebody code review this one ? |
steveisok
approved these changes
Sep 20, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58866 to release/6.0-rc2
/cc @steveisok @directhex
We have four classes of symbols missing at VS insertion, according to validation:
tasks - we were producing ppdb's but not packaging them in the .symbols.nuget, this PR addresses that
wasm tasks - we are already producing and shipping ppdb's, implies an issue with ppdb->pdb conversion affecting insertion
mono-aot-cross.exe - we were not producing pdb's, this PR addresses that
llvm (llc and opt) - we will be filing an exception to exclude them from the symbol validation
Customer Impact
There is no direct impact as this change seeks to satisfy the symbol validation that occurs during VS insertion.
Testing
We were able to evaluate the symbols were ok via symchk.exe and that our change did not break the official build
Risk
Minimal