[release/6.0-rc2] [interp] Disable optimization if the var index is greater than G_MAXUINT16 #59261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…INT16 We store the var index in the guint16 slots of the instruction
|
Tagging subscribers to this area: @BrzVlad Issue DetailsBackport of #59225 to release/6.0-rc2 /cc @lambdageek @BrzVlad Customer ImpactTestingRisk
|
BrzVlad
approved these changes
Sep 17, 2021
jamshedd
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #59225 to release/6.0-rc2
/cc @lambdageek @BrzVlad
Customer Impact
When the Mono Interpreter is executing certain large methods, it may incorrectly optimize the initialization of some function call arguments resulting in data corruption.
This is a regression caused by #52242
This is a fairly unlikely scenario (large method with a certain call structure) for human-written code, but might be possible in generated code. On WebAssembly there may not be a good workaround.
Testing
CI
Risk
Low. This change is just inhibiting an optimization in more cases.