Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release/6.0]fix the package version for non-shipping csproj packages #59369

Merged
merged 2 commits into from
Sep 21, 2021
Merged

[Release/6.0]fix the package version for non-shipping csproj packages #59369

merged 2 commits into from
Sep 21, 2021

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented Sep 20, 2021

We override the Arcade package version with custom $(ServicingVersion) for each package, hence in some cases end up removing the version suffix
Version suffix is applied by the arcade whenever it is non-empty. Following the same convention here

@ghost
Copy link

ghost commented Sep 20, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

We override the Arcade package version with custom $(ServicingVersion) for each package, hence in some cases end up removing the version suffix
Version suffix is applied by the arcade whenever it is non-empty. Following the same convention here

Author: Anipik
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@Anipik Anipik changed the title fix the package version for non-shipping csproj packages [Release/6.0]fix the package version for non-shipping csproj packages Sep 20, 2021
eng/packaging.targets Outdated Show resolved Hide resolved
@Anipik Anipik merged commit da9d377 into dotnet:release/6.0 Sep 21, 2021
@Anipik Anipik deleted the packageVersion branch September 21, 2021 00:47
@Anipik
Copy link
Contributor Author

Anipik commented Sep 21, 2021

/backport to main

@github-actions
Copy link
Contributor

Started backporting to main: https://github.com/dotnet/runtime/actions/runs/1255743031

@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants