Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 6.0 rc2 localized manifest #59379

Merged

Conversation

wli3
Copy link

@wli3 wli3 commented Sep 20, 2021

@ghost
Copy link

ghost commented Sep 20, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Part of dotnet/sdk#20497

Author: wli3
Assignees: -
Labels:

area-System.Net

Milestone: -

@ghost
Copy link

ghost commented Sep 21, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Part of dotnet/sdk#20497

Author: wli3
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

@danroth27 any objections?

@danroth27
Copy link
Member

No objections from me.

@wli3
Copy link
Author

wli3 commented Sep 21, 2021

@lewing @steveisok could you help me merge it? I don't have the permission

@wli3
Copy link
Author

wli3 commented Sep 21, 2021

?

@steveisok steveisok added Servicing-consider Issue for next servicing release review Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 21, 2021
@steveisok
Copy link
Member

Approved by tactics over email.

@steveisok steveisok merged commit 307d945 into dotnet:release/6.0-rc2 Sep 21, 2021
sfoslund pushed a commit that referenced this pull request Oct 1, 2021
steveisok pushed a commit that referenced this pull request Oct 4, 2021
Fixing a bug in #59379, part of dotnet/sdk#20497

Workload/SDK logic only copies content in the data directory, so moving the localize directory into the proper location to be picked up and laid down on disk.
@karelz karelz added this to the 6.0.0 milestone Oct 14, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants