[release/6.0] Fix gtCloneExpr when cloning during R2R compilation a GT_ALLOCOBJ node #59421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…e - Without this fix cloned expressions with allocations will fail - This is most common in profile guided code around devirtualization, but I believe it can occur in other where gtCloneExpr is used - Symptom of the failure is a compilation failure during crossgen2
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsBackport of #59395 to release/6.0 /cc @davidwrighton Customer ImpactTestingRisk
|
davidwrighton
added
the
Servicing-consider
AndyAyersMS
approved these changes
Sep 21, 2021
jeffschwMSFT
approved these changes
Sep 21, 2021
|
@davidwrighton we are still considering fixes for RC2. I think we should consider it for RC2, do you? |
|
@jeffschwMSFT I thought we had missed that cutoff. I'll put together the RC2 PR as well. |
|
We are really close. You might want to request approval for this including considering for RC2. |
|
/backport to release/6.0-rc2 |
|
Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1259619216 |
|
This was merged into RC2 directly via #59438 instead. Thus I'm closing this PR. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #59395 to release/6.0
/cc @davidwrighton
Customer Impact
Under conditions I am unable to identify that will sometimes cause the JIT to generate data structures vulnerable to this bug if the type of localVariable can be predicted via PGO.
Testing
Standard PR run + targeted testing of the PGO scenario which failed without this fix.
Risk
Low. This fixes a logic error in the jit that would cause prejitting of a method to fail.