Retry installer Process.Start if ETXTBSY #59765
Conversation
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
| { | ||
| // 10 ms is short, but the race we're trying to avoid is in-between | ||
| // "fork" and "exec", so it should be fast | ||
| Thread.Sleep(10); |
There was a problem hiding this comment.
Ideally this should print out some diagnostics - so that we know it happened. Not sure if Console.WriteLine is the correct solution here - but it might be.
There was a problem hiding this comment.
Console.WriteLine is captured by XUnit so I don't think that would work.
Why would this code in particular be worthy of a diagnostic? I've found a few other places where we appear to retry without warning, e.g. in TestFileBackup:
// Directory.Delete sometimes fails with error that the directory is not empty.
// This is a known problem where the actual Delete call is not 100% synchronous
// the OS reports a success but the file/folder is not fully removed yet.
// So implement a simple retry with a short timeout.
IOException exception = null;
for (int retryCount = 5; retryCount > 0; retryCount--)
{
try
{
Directory.Delete(_backupPath, recursive: true);
if (!Directory.Exists(_backupPath))
{
return;
}
}
catch (IOException ex)
{
exception = ex;
}
System.Threading.Thread.Sleep(200);
}
There was a problem hiding this comment.
Since this has been giving us trouble, having enough info to diagnose potential issues sounds like a good idea.
I know that we don't have existing diagnostics, but ideally that should not block us from adding them 😉.
That said - I don't know how the diagnostics should look. Is there some existing mechanism for tests to output additional info to be used in case of failure (but honestly it would be great to get this even on passes if it's not too verbose).
There was a problem hiding this comment.
Unfortunately I don't know of a good logging mechanism at the moment. This code could be executed across many threads, so there would likely need to be some coordination for anything useful to come out.
| catch (Win32Exception e) when (e.Message.Contains("Text file busy")) | ||
| { | ||
| // 10 ms is short, but the race we're trying to avoid is in-between | ||
| // "fork" and "exec", so it should be fast |
There was a problem hiding this comment.
to balance latency and likelihood of waiting long enough, perhaps we should scale the backoff a little, like this could be Sleep(i * 10) ?
There was a problem hiding this comment.
It's probably worth seeing if this solves the issue, but there's no reason we can't come back to it later.
ghost
locked as resolved and limited conversation to collaborators
Caused by #58964
Fixes #53587