Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retry when downloading clang tools #59806

Merged
merged 3 commits into from
Sep 30, 2021
Merged

Fix retry when downloading clang tools #59806

merged 3 commits into from
Sep 30, 2021

Commits on Sep 30, 2021

  1. Fix retry when downloading clang tools 

    Invoke-WebRequest throws an exception when the download fails, so we
should use try-catch instead of status code to check failure.

In addition pass -PassThru to avoid leaving a corrupted download file in
case the download fails. This will buffer the download and write it once
at the end.

Fix dotnet#57196
    @jakobbotsch
    jakobbotsch committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    4f2331d View commit details
    Browse the repository at this point in the history

  2. Add -UseBasicParsing as well

    @jakobbotsch
    jakobbotsch committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    0a006f6 View commit details
    Browse the repository at this point in the history

  3. Use Retry function from tools.ps1

    @jakobbotsch
    jakobbotsch committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    cd689b5 View commit details
    Browse the repository at this point in the history