[release/6.0] Fix NRT warnings in source generated code #59817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
eiriktsarpalis,
layomia and
steveharter
as code owners
|
Tagging subscribers to this area: @dotnet/area-system-text-json Issue DetailsBackport of #59755 to release/6.0 /cc @eiriktsarpalis Customer ImpactTestingRisk
|
|
Does the Logging SG have the same issue? |
@maryamariyan might know cf. #59464 for a repro in the STJ case. |
|
@maryamariyan @dotnet/area-extensions-logging ? |
thanks for the ping, I need to investigate this for logging |
|
approved in email. |
Anipik
approved these changes
Oct 1, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #59755 to release/6.0
/cc @eiriktsarpalis
Customer Impact
The System.Text.Json source generator produces nullability warnings when generating code for types containing nullable properties. This can result in compiler errors for projects that treat warnings as errors and forces users to disable nullable annotations project-wide. This is a customer reported bug.
Testing
Tests have been added that validate that the impacted use cases compile as expected.
Risk
Low. Updates the product code so that suppressions are inserted on expressions that require it.