Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0][wasm] Fix codeql checks #59839

Merged
merged 3 commits into from
Oct 6, 2021

Conversation

lewing
Copy link
Member

@lewing lewing commented Sep 30, 2021

Fixes #59147 for release/6.0 a console method is called
with both a concatenated format string and multiple arguments.

Customer Impact

Avoids scanning errors in the shipped javascript.

Testing

Manual

Risk

Tiny

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@lewing lewing changed the title [release/6.0] Fix codeql checks [release/6.0][wasm] Fix codeql checks Sep 30, 2021
@ghost
Copy link

ghost commented Sep 30, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #59147 for release/6.0 a console method is called
with both a concatenated format string and multiple arguments.

Customer Impact

Avoids scanning errors in the shipped javascript.

Testing

Manual

Risk

Tiny

Author: lewing
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@ghost
Copy link

ghost commented Sep 30, 2021

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #59147 for release/6.0 a console method is called
with both a concatenated format string and multiple arguments.

Customer Impact

Avoids scanning errors in the shipped javascript.

Testing

Manual

Risk

Tiny

Author: lewing
Assignees: -
Labels:

area-VM-meta-mono

Milestone: -

src/mono/wasm/runtime/library_mono.js Outdated Show resolved Hide resolved
src/mono/wasm/runtime/library_mono.js Outdated Show resolved Hide resolved
fix quote type
@lewing lewing requested a review from kg October 1, 2021 15:26
and fix the other typo
@lewing lewing added Servicing-consider Issue for next servicing release review Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 6, 2021
@lewing
Copy link
Member Author

lewing commented Oct 6, 2021

approved in email

@lewing lewing added this to the 6.0.0 milestone Oct 6, 2021
@steveisok steveisok merged commit 5e9e865 into dotnet:release/6.0 Oct 6, 2021
@lewing lewing deleted the release-codeql branch October 7, 2021 01:12
@ghost ghost locked as resolved and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-meta-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants