[release/6.0] Fix code heap reservation size #59918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
When I've moved the heap metadata out of the actual code heaps some time ago, I've forgotten to account for the personality routine slot allocated at the beginning of the heaps. This was exposed by an assert when executing under the JIT stress mode 2. This change fixes it by adding accounting for those. Close #59794
jeffschwMSFT
approved these changes
Oct 4, 2021
jkotas
approved these changes
Oct 4, 2021
jeffschwMSFT
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #59883 to release/6.0
/cc @janvorli
Customer Impact
Methods with huge amount of code can cause crashes at runtime due to not enough memory reserved for the related code heap. This happens when the code heap reservation size is above a minimum reservation (64kB on 32 bit platforms, 512kB on 64 bit platforms) and it is less than 16 bytes smaller than a virtual memory allocation granularity multiple.
Testing
CoreCLR pri 1 tests.
Risk
Low, the fix just enlarges size of memory reservation for code heap in the affected cases by 16 bytes.