Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Update signed wix version for arm64 fixes #60008

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

lewing
Copy link
Member

@lewing lewing commented Oct 5, 2021

Tell mode packaging related tooling update.

Updated WiX build that contains changes to better support x64 emulation on arm64. This is needed for 6.0.

Fixes the mono workload side of #60003

@ghost
Copy link

ghost commented Oct 5, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Tell mode packaging related tooling upadate.

Fixes the mono workload side of #60003

Author: lewing
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@lewing lewing added packaging Related to packaging and removed area-Infrastructure-libraries labels Oct 5, 2021
@lewing lewing requested a review from steveisok October 5, 2021 16:54
@lewing lewing added the Servicing-consider Issue for next servicing release review label Oct 5, 2021
@ghost
Copy link

ghost commented Oct 5, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Tell mode packaging related tooling update.

Fixes the mono workload side of #60003

Author: lewing
Assignees: -
Labels:

Servicing-consider, packaging, area-Infrastructure

Milestone: -

@lewing lewing changed the title [release/6.0] Update signed wix version to 1.0.0-v3.14.0.5722 [release/6.0] Update signed wix version for arm64 fixes Oct 5, 2021
@lewing lewing requested a review from joeloff October 5, 2021 17:55
@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-approved Approved for servicing release Servicing-consider Issue for next servicing release review labels Oct 5, 2021
@lewing
Copy link
Member Author

lewing commented Oct 5, 2021

tell mode email sent, can someone please merge

@ericstj ericstj merged commit 153c294 into dotnet:release/6.0 Oct 6, 2021
@ericstj
Copy link
Member

ericstj commented Oct 6, 2021

/backport to main

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

Started backporting to main: https://github.com/dotnet/runtime/actions/runs/1310345085

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

@ericstj backporting to main failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Update signed wix version to 1.0.0-v3.14.0.5722
Using index info to reconstruct a base tree...
M	eng/Versions.props
Falling back to patching base and 3-way merge...
Auto-merging eng/Versions.props
CONFLICT (content): Merge conflict in eng/Versions.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update signed wix version to 1.0.0-v3.14.0.5722
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants