Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI matrix update: add Ubuntu 21.04 - second attempt #60162

Merged
merged 3 commits into from
Dec 9, 2021

Conversation

aik-jahoda
Copy link
Contributor

The original CI matrix change was reverted (#60040) because of a failing CI.

part of #57947

original PR: #59578

@ViktorHofer
Copy link
Member

ViktorHofer commented Oct 25, 2021

Same comment as in your other PR:

I didn't check the yml. Does this added queue only run as part of a rolling build? If so, can you please queue up a build with your changes to make sure that the changes work as expected?

@hoyosjs
Copy link
Member

hoyosjs commented Oct 25, 2021

Same comment as in your other PR:

I didn't check the yml. Does this added queue only run as part of a rolling build? If so, can you please queue up a build with your changes to make sure that the changes work as expected?

As it stands now - it would only run in a rolling build

@aik-jahoda aik-jahoda closed this Nov 25, 2021
@aik-jahoda aik-jahoda reopened this Nov 25, 2021
@aik-jahoda aik-jahoda removed the request for review from Anipik November 29, 2021 13:57
@karelz
Copy link
Member

karelz commented Nov 29, 2021

@safern @ericstj can you please review the PR? Then we can merge (and backport to .NET 6.0). Thanks!

@karelz karelz requested a review from ericstj November 29, 2021 15:56
@ericstj
Copy link
Member

ericstj commented Nov 29, 2021

I believe there is an open question from reviewers above which requires attention:

Does this added queue only run as part of a rolling build? If so, can you please queue up a build with your changes to make sure that the changes work as expected?

As it stands now - it would only run in a rolling build

@aik-jahoda Can you share the results of the rolling build which tests your changes?

@aik-jahoda
Copy link
Contributor Author

@safern, @ericstj , can you please take a look?

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @safern do you agree?

@ericstj
Copy link
Member

ericstj commented Dec 8, 2021

Actually, I'm not entirely certain how to interpret all these failures in the other legs. I see the linked log shows at least one pass on the new queues. Do you understand the other failures?

Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@aik-jahoda aik-jahoda merged commit 546e517 into main Dec 9, 2021
@karelz karelz added this to the 7.0.0 milestone Dec 9, 2021
@safern safern deleted the jajahoda/matrixubuntu2104 branch December 10, 2021 21:48
@ghost ghost locked as resolved and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants