Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] [reflection] Initialize default ALC gchandle in GetLoadContext #60399

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 14, 2021

Backport of #60350 to release/6.0

/cc @lambdageek

Related to #60348

Customer Impact

Customers looking to use the github actions test runner on s390x will experience crashes.

If possible, I'd like to see this fix backported, since it fixes a serious problem - without that patch, the github runner crashes on startup, and the runner is definitely one of the apps we want to run on s390x.

Also, that pattern of installing an Unloading handler (which is triggering the crash) seems one that is probably used elsewhere too.

There is potential impact on all platforms.

Testing

CI and manual testing

Risk

Low.

In many scenarios the managed object for the default ALC is already created, so the change is a no-op.

If we try to get the ALC of an assembly from the default context before the
managed default ALC object has been created, the native gchandle has a null
target.
Ensure it is not null by explicitly referencing the Default ALC.

Fixes #60348
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@marek-safar marek-safar added this to the 6.0.0 milestone Oct 14, 2021
@marek-safar marek-safar added the Servicing-consider Issue for next servicing release review label Oct 14, 2021
@ghost
Copy link

ghost commented Oct 14, 2021

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #60350 to release/6.0

/cc @lambdageek

Related to #60348

Customer Impact

Customers looking to use the github actions test runner on s390x will experience crashes.

If possible, I'd like to see this fix backported, since it fixes a serious problem - without that patch, the github runner crashes on startup, and the runner is definitely one of the apps we want to run on s390x.

Also, that pattern of installing an Unloading handler (which is triggering the crash) seems one that is probably used elsewhere too.

There is potential impact on all platforms.

Testing

CI and manual testing

Risk

Low.

In many scenarios the managed object for the default ALC is already created, so the change is a no-op.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, area-VM-meta-mono

Milestone: 6.0.0

@lambdageek
Copy link
Member

Approved in email.

@lambdageek lambdageek added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 15, 2021
@mmitche mmitche merged commit a1c550c into release/6.0 Oct 15, 2021
@mmitche mmitche deleted the backport/pr-60350-to-release/6.0 branch October 16, 2021 00:01
@ghost ghost locked as resolved and limited conversation to collaborators Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-meta-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants