[release/6.0] Remove duplicate entries from dotnet --info #60446
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
|
approved over mail. Test failure is Probably just a coincidence that this is in a host test, right? Especially since we only change the windows PAL. Rerunning though to increase confidence that I didn't cause some butterfly effect. |
|
That failure is fixed in 7 (right @agocke?), and it's a completely random failure affecting all single-file tests, but basically nothing else. |
|
Sorry for the delay -- yes this race should be fixed in |
ghost
locked as resolved and limited conversation to collaborators
Backport of #60376 to release/6.0
/cc @ericstj
Customer Impact
Customers see duplicate entries in
dotnet --infofor all SDKs and all frameworks when running in the default install on Windows. Regression introduced in RC2. This isn't blocking but it looks pretty bad.Testing
Manually tested end-to-end to verify fix (shown below). Added automated regression test.
Risk
Very low. Leverages existing method in a new place.
Root cause
We are writing a trailing slash on
InstallLocationand the host didn't remove this when considering paths (though it does for other paths). The result is that it considersC:\Program Files\dotnetandC:\Program Files\dotnet\to be separate paths, causing duplicates. Fixing this to avoid the trailing slash in the installer requires a custom action. The reason it worked before was because the installer was using hard-coded strings to write these values. We changed that in ARM64 work to calculate these directories. MSI insists on directories ending in a trailing slash.Result before:
After: