Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Int32 overflow bug in buffering logic #60459

Merged
merged 5 commits into from
Oct 15, 2021
Merged

Fix Int32 overflow bug in buffering logic #60459

merged 5 commits into from
Oct 15, 2021

Commits on Oct 15, 2021

  1. add a failing test

    @adamsitnik
    adamsitnik committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    313eca3 View commit details
    Browse the repository at this point in the history

  2. fix the bug in BufferedFileStreamStrategy

    @adamsitnik
    adamsitnik committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    6534205 View commit details
    Browse the repository at this point in the history

  3. extend the test and fix it in the BufferedStream as well

    @adamsitnik
    adamsitnik committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    4df8f9c View commit details
    Browse the repository at this point in the history

  4. large files are currently not supported on WASM

    @adamsitnik
    adamsitnik committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    340e596 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Carlos Sanchez <[email protected]>
    @adamsitnik @carlossanlop
    adamsitnik and carlossanlop authored Oct 15, 2021
    Configuration menu
    Copy the full SHA
    a6fc59c View commit details
    Browse the repository at this point in the history