Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0] Update IntelliSense package #60488

Merged
merged 1 commit into from
Oct 18, 2021
Merged

[release/6.0] Update IntelliSense package #60488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@
<FsCheckVersion>2.14.3</FsCheckVersion>
<SdkVersionForWorkloadTesting>6.0.100-rtm.21480.21</SdkVersionForWorkloadTesting>
<!-- Docs -->
<MicrosoftPrivateIntellisenseVersion>6.0.0-preview-20210916.1</MicrosoftPrivateIntellisenseVersion>
<MicrosoftPrivateIntellisenseVersion>6.0.0-preview-20211015.1</MicrosoftPrivateIntellisenseVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be interesting to just do a diff test of this to make sure nothing stands out (like dropped files or something). I don't think we have a lot of validation for that. It could be a cheap test to do to reduce risk: use Beyond Compare or something to diff the two nuget package directories.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericstj @safern I created a branch in the api-catalog-infra repo where I uploaded the contents of the contents of the last nuget package (RC1) as the baseline, then I submitted this PR with the contents of the RTM package, to see the diff.

The diff looks good for the modified files, but I noticed there is a new file: IntellisenseFiles/net-6.0/System.Text.Json.SourceGeneration.xml . Do you think having this xml would be problematic?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: I realized I decompressed the zip file incorrectly. I first had to delete everything from the baseline folder, then extract the contents of the new file in place. The WPF and WinForms xml files are all missing. I'll investigate this with the Docs team.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was accidentally merged, but it was promptly reverted. I will create a new backport PR.

<!-- ILLink -->
<MicrosoftNETILLinkTasksVersion>6.0.100-1.21459.1</MicrosoftNETILLinkTasksVersion>
<MicrosoftNETILLinkAnalyzerPackageVersion>$(MicrosoftNETILLinkTasksVersion)</MicrosoftNETILLinkAnalyzerPackageVersion>
Expand Down