Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error 'The following files are missing entries in the templated manifest' #60580

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

SteveDunn
Copy link
Contributor

@SteveDunn SteveDunn commented Oct 18, 2021

Fixes 60526

Description

Updated PlatformManifestFileEntry to include new SDK item 'api-ms-win-core-fibers-l1-1-0.dll' that is seen in Windows SDK 10.0.22000.0

Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good.

@@ -119,6 +119,7 @@
<PlatformManifestFileEntry Include="libmscordbi.so" IsNative="true" />
<PlatformManifestFileEntry Include="libmscordbi.dylib" IsNative="true" />
<PlatformManifestFileEntry Include="mscorrc.dll" IsNative="true" />
<PlatformManifestFileEntry Include="api-ms-win-core-fibers-l1-1-0.dll" IsNative="true" FallbackFileVersion="$(WindowsForwarderFileVersion)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please move this down to before api-ms-win-core-file*, we try to keep this in alphabetical order.

@hoyosjs
Copy link
Member

hoyosjs commented Oct 19, 2021

Error in WASM leg is known issue #60234. Thanks for the fix @SteveDunn

@hoyosjs hoyosjs added the community-contribution Indicates that the PR has been added by a community member label Oct 19, 2021
@hoyosjs hoyosjs merged commit f40d005 into dotnet:main Oct 19, 2021
@SteveDunn SteveDunn deleted the 60526-update-PlatformManifestFileEntry branch October 19, 2021 08:41
@ghost ghost locked as resolved and limited conversation to collaborators Nov 18, 2021
@mangod9
Copy link
Member

mangod9 commented Feb 23, 2022

/backport to release/6.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-installer community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants